linux-kernel - Re: [PATCH v9 14/15] media: imx-asrc: Add memory to memory driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6e39566-f872-4bae-83e4-212e75e705dc@kernel.org>
Date:   Thu, 16 Nov 2023 12:15:21 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Shengjiu Wang <shengjiu.wang@...il.com>
Cc:     Shengjiu Wang <shengjiu.wang@....com>, hverkuil@...all.nl,
        sakari.ailus@....fi, tfiga@...omium.org, m.szyprowski@...sung.com,
        mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xiubo.Lee@...il.com,
        festevam@...il.com, nicoleotsuka@...il.com, lgirdwood@...il.com,
        broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
        alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v9 14/15] media: imx-asrc: Add memory to memory driver

On 16/11/2023 09:32, Shengjiu Wang wrote:

>>> +MODULE_DESCRIPTION("Freescale ASRC M2M driver");
>>> +MODULE_ALIAS("platform:" M2M_DRV_NAME);
>>
>> You should not need MODULE_ALIAS() in normal cases. If you need it,
>> usually it means your device ID table is wrong (e.g. misses either
>> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
>> for incomplete ID table.
> 
> 
> This driver don't have MODULE_DEVICE_TABLE.  it is only registered
> by platform_device_register_data().

Which is the problem. I thought I made myself clear but if it is not the
case: drop MODULE_ALIAS.

Best regards,
Krzysztof