linux-kernel - RE: [PATCH v2] scsi: ufs: core: fix racing issue during ufshcd_mcq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00a901da1830$16ff2e10$44fd8a30$@samsung.com>
Date:   Thu, 16 Nov 2023 10:56:18 +0900
From:   "hoyoung seo" <hy50.seo@...sung.com>
To:     "'Bart Van Assche'" <bvanassche@....org>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <beanhuo@...ron.com>, <kwangwon.min@...sung.com>,
        <kwmad.kim@...sung.com>, <sh425.lee@...sung.com>,
        <sc.suh@...sung.com>, <quic_nguyenb@...cinc.com>,
        <cpgs@...sung.com>, <grant.jung@...sung.com>,
        <junwoo80.lee@...sung.com>
Subject: RE: [PATCH v2] scsi: ufs: core: fix racing issue during
 ufshcd_mcq_abort

> -----Original Message-----
> From: Bart Van Assche <bvanassche@....org>
> Sent: Thursday, November 16, 2023 3:22 AM
> To: hoyoung seo <hy50.seo@...sung.com>; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; alim.akhtar@...sung.com; avri.altman@....com;
> jejb@...ux.ibm.com; martin.petersen@...cle.com; beanhuo@...ron.com;
> kwangwon.min@...sung.com; kwmad.kim@...sung.com; sh425.lee@...sung.com;
> sc.suh@...sung.com; quic_nguyenb@...cinc.com; cpgs@...sung.com;
> grant.jung@...sung.com; junwoo80.lee@...sung.com
> Subject: Re: [PATCH v2] scsi: ufs: core: fix racing issue during
> ufshcd_mcq_abort
> 
> On 11/14/23 21:27, hoyoung seo wrote:
> > The test_bit() function just check SCMD_STATE_COMPLETE bit state.
> > Do not set SCMD_STATE_COMPLETE field.
> > This function is also used in ufshcd_mcq_compl_pending_transfer()
> > to check the status of cmd.
> 
> Right, I misread your patch. Can you please take a look at the following
> patch and verify whether it perhaps addresses the same issue that you want
> to address: https://lore.kernel.org/linux-scsi/20231115131024.15829-1-
> peter.wang@...iatek.com/
> 
> Thanks,
> 
> Bart.

Hi, Bart.

It seem that not same issue.
That problem is that the try_to_abort_task() function has already been 
processed.
So clear_cmd() has been processed.

However, this issue was already completed IO request before executing clear_cmd().
So can't get utag to clean up sq.
This patch to prevent access to utag for cmd that has already been completed.

Thanks
Seo.