linux-kernel - Re: [PATCH] arm64/kvm: Introduce feature extension for SMCCC filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877cmhq1zp.fsf@redhat.com>
Date:   Thu, 16 Nov 2023 14:08:58 +0100
From:   Cornelia Huck <cohuck@...hat.com>
To:     Jianyong Wu <jianyong.wu@....com>, maz@...nel.org,
        james.morse@....com, will@...nel.org
Cc:     rmk@...linux.org.uk, salil.mehta@...wei.com,
        suzuki.poulose@....com, oliver.upton@...ux.dev,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
        linux-kernel@...r.kernel.org, justin.he@....com,
        jianyong.wu@....com
Subject: Re: [PATCH] arm64/kvm: Introduce feature extension for SMCCC filter

On Thu, Nov 16 2023, Jianyong Wu <jianyong.wu@....com> wrote:

> 821d935c87b introduces support for userspace SMCCC filtering, but lack
> of a way to tell userspace if we have this feature. Add a corresponding
> feature extension can resolve this issue.
>
> For example, the incoming feature Vcpu Hotplug needs the SMCCC filter.
> As there is no way to check this feature, VMM will run into error when
> it calls this feature on an old kernel. It's bad for backward compatible.

Can't you simply query via KVM_HAS_DEVICE_ATTR whether the SMCCC
filtering controls exist?

>
> Signed-off-by: Jianyong Wu <jianyong.wu@....com>
> ---
>  Documentation/virt/kvm/api.rst | 3 ++-
>  arch/arm64/kvm/arm.c           | 1 +
>  include/uapi/linux/kvm.h       | 1 +
>  3 files changed, 4 insertions(+), 1 deletion(-)
>