[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231116150357.6a2fa8f9@endymion.delvare>
Date: Thu, 16 Nov 2023 15:03:57 +0100
From: Jean Delvare <jdelvare@...e.de>
To: "Gabriel L. Somlo" <gsomlo@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Karol Gugala <kgugala@...micro.com>,
Mateusz Holenko <mholenko@...micro.com>,
Joel Stanley <joel@....id.au>
Subject: Re: [PATCH] drivers/soc/litex: drop obsolete dependency on
COMPILE_TEST
Hi Gabriel,
On Fri, 25 Nov 2022 09:00:02 -0500, Gabriel L. Somlo wrote:
> On Thu, Nov 24, 2022 at 04:16:18PM +0100, Jean Delvare wrote:
> > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> > is possible to test-build any driver which depends on OF on any
> > architecture by explicitly selecting OF. Therefore depending on
> > COMPILE_TEST as an alternative is no longer needed.
> >
> > It is actually better to always build such drivers with OF enabled,
> > so that the test builds are closer to how each driver will actually be
> > built on its intended target. Building them without OF may not test
> > much as the compiler will optimize out potentially large parts of the
> > code. In the worst case, this could even pop false positive warnings.
> > Dropping COMPILE_TEST here improves the quality of our testing and
> > avoids wasting time on non-existent issues.
> >
> > As a minor optimization, this also lets us drop of_match_ptr() and
> > ifdef-guarding, as we now know what they will resolve to, we might as
> > well save cpp some work.
>
> Acked-by: Gabriel Somlo <gsomlo@...il.com>
Despite your ack, this patch was never committed. Was it forgotten
somehow? Should I resubmit?
Thanks,
--
Jean Delvare
SUSE L3 Support
Powered by blists - more mailing lists