linux-kernel - Re: [PATCH] dt-bindings: thermal: convert Mediatek Thermal to the json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b475d496-c97b-4178-9cdb-6f7d640e9877@linaro.org>
Date:   Thu, 16 Nov 2023 15:38:35 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rafał Miłecki <zajec5@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH] dt-bindings: thermal: convert Mediatek Thermal to the
 json-schema

On 16/11/2023 13:02, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> This helps validating DTS files.
> 

...

mal.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal.yaml
> new file mode 100644
> index 000000000000..0e036b22b82b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.yaml

mediatek,thermal.yaml

> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek-thermal.yaml#

mediatek,thermal.yaml

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Thermal

SoC? PMIC?

> +
> +description: >

Drop >

> +  This describes the device tree binding for the Mediatek thermal controller

Drop redundant part. Describe hardware, not the binding. There is no
point to say that a binding describes a binding.

> +  which measures the on-SoC temperatures. This device does not have its own ADC,
> +  instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +  this device needs phandles to the AUXADC. Also it controls a mux in the
> +  apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
> +  is also needed.
> +
> +allOf:

...

> +  mediatek,auxadc:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: A phandle to the AUXADC which the thermal controller uses
> +
> +  mediatek,apmixedsys:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: A phandle to the APMIXEDSYS controller
> +
> +  resets: Reference to the reset controller controlling the thermal controller.
> +

Not tested. You miss constraints. Drop totally redundant description.

> +
> +unevaluatedProperties: false
> +
> +required:
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - mediatek,auxadc
> +  - mediatek,apmixedsys

unevaluatedProperties go here.

Best regards,
Krzysztof