linux-kernel - Re: [PATCH 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2023 15:46:33 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     James Tai [戴志峰] <james.tai@...ltek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-realtek-soc@...ts.infradead.org" 
        <linux-realtek-soc@...ts.infradead.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>
Subject: Re: [PATCH 1/6] dt-bindings: interrupt-controller: Add support for
 Realtek DHC SoCs

On 16/11/2023 15:37, James Tai [戴志峰] wrote:
> Hi Krzysztof,
> 
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can
>> be ignored, but the code here looks like it needs a fix.
>> Feel free to get in touch if the warning is not clear.
>>
> 
> I will run checkpatch.pl to address and fix the reported warnings.
> 
>> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>> to CC. It might happen, that command when run on an older kernel, gives you
>> outdated entries. Therefore please be sure you base your patches on recent
>> Linux kernel.
>>
>> You missed at least devicetree list (maybe more), so this won't be tested by
>> automated tooling. Performing review on untested code might be a waste of
>> time, thus I will skip this patch entirely till you follow the process allowing the
>> patch to be tested.
>>
>> Please kindly resend and include all necessary To/Cc entries.
> 
> I will fix it in the next patches.
> 
>>
>> It does not look like you tested the bindings, at least after quick look. Please run
>> `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
>>
> I will test the bindings using 'make dt_binding_check'.

Please do all above before submitting patches.

Best regards,
Krzysztof