linux-kernel - RE: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2023 15:29:25 +0000
From:   James Tai [戴志峰] <james.tai@...ltek.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-realtek-soc@...ts.infradead.org" 
        <linux-realtek-soc@...ts.infradead.org>
CC:     Marc Zyngier <maz@...nel.org>
Subject: RE: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver

Hi Thomas,

>> +enum rtd1319_iso_isr_bits {
>> +     RTD1319_ISO_ISR_TC3_SHIFT = 1,
>> +     RTD1319_ISO_ISR_UR0_SHIFT = 2,
>
>Please use tabular formatting all over the place.

I will fix it in the next patches.

>
>> +     RTD1319_ISO_ISR_LSADC0_SHIFT = 3,
>> +     RTD1319_ISO_ISR_IRDA_SHIFT = 5,
>> +
>
>
>> +static const struct realtek_intc_info rtd1319_intc_iso_info = {
>> +     .isr_offset = 0x0,
>> +     .umsk_isr_offset = 0x4,
>> +     .scpu_int_en_offset = 0x40,
>
>Magic numbers. Defines exist for a reason.

I will fix it in the next patches.

Thank you for your feedback.

Regards,
James