linux-kernel - RE: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking fields from iavf_adminq_ring

Open Source and information security mailing list archives

Message-ID: <BL0PR11MB3521C0334FF07B3C3DD69D9D8FB0A@BL0PR11MB3521.namprd11.prod.outlook.com>
Date:   Thu, 16 Nov 2023 15:52:06 +0000
From:   "Romanowski, Rafal" <rafal.romanowski@...el.com>
To:     Simon Horman <horms@...nel.org>, ivecera <ivecera@...hat.com>
CC:     "Drewek, Wojciech" <wojciech.drewek@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Keller, Jacob E" <jacob.e.keller@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking
 fields from iavf_adminq_ring

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: Friday, November 3, 2023 6:09 PM
> To: ivecera <ivecera@...hat.com>
> Cc: Drewek, Wojciech <wojciech.drewek@...el.com>;
> netdev@...r.kernel.org; Brandeburg, Jesse <jesse.brandeburg@...el.com>;
> linux-kernel@...r.kernel.org; Eric Dumazet <edumazet@...gle.com>;
> Nguyen, Anthony L <anthony.l.nguyen@...el.com>; intel-wired-
> lan@...ts.osuosl.org; Keller, Jacob E <jacob.e.keller@...el.com>; Jakub Kicinski
> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David S. Miller
> <davem@...emloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking
> fields from iavf_adminq_ring
> 
> On Thu, Oct 26, 2023 at 10:39:32AM +0200, Ivan Vecera wrote:
> > Fields 'head', 'tail', 'len', 'bah' and 'bal' in iavf_adminq_ring are
> > used to store register offsets. These offsets are initialized and
> > remains constant so there is no need to store them in the
> > iavf_adminq_ring structure.
> >
> > Remove these fields from iavf_adminq_ring and use register offset
> > constants instead. Remove iavf_adminq_init_regs() that originally
> > stores these constants into these fields.
> >
> > Finally improve iavf_check_asq_alive() that assumes that non-zero
> > value of hw->aq.asq.len indicates fully initialized AdminQ send queue.
> > Replace it by check for non-zero value of field hw->aq.asq.count that
> > is non-zero when the sending queue is initialized and is zeroed during
> > shutdown of the queue.
> >
> > Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> 
> Thanks, this is a nice cleanup.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> ...
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives