linux-kernel - Re: [PATCH v3 10/13] scsi: fnic: Add support for multiqueue (MQ) in fnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3d03635-3b4c-44d0-8e16-a9d3a1b4cc92@oracle.com>
Date:   Thu, 16 Nov 2023 17:30:41 +0000
From:   John Garry <john.g.garry@...cle.com>
To:     "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>,
        "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>
Cc:     "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
        "Dhanraj Jhawar (djhawar)" <djhawar@...co.com>,
        "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>,
        "Masa Kai (mkai2)" <mkai2@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v3 10/13] scsi: fnic: Add support for multiqueue (MQ) in
 fnic_main.c

On 16/11/2023 16:32, John Garry wrote:
> 
> If you check blk_mq_update_queue_map(), for set->ops->map_queues unset 
> we call blk_mq_map_queues() - I am just wondering what does the 
> equivalent to blk_mq_map_queues() for you in these other modes.
> 
> I am concerned that it is not proper that we have a set->ops->map_queues 
> method, but it does nothing in some scenarios.

I think we get away with this as mq_map[for all CPUs] is 0, which points 
to the only HW queue.

Thanks,
John