linux-kernel - Re: [PATCH v4 3/5] dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2023 11:41:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Binbin Zhou <zhoubinbin@...ngson.cn>
Cc:     WANG Xuerui <git@...0n.name>, Rob Herring <robh+dt@...nel.org>,
        linux-mips@...r.kernel.org, lvjianmin@...ngson.cn,
        Huacai Chen <chenhuacai@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        loongson-kernel@...ts.loongnix.cn,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Binbin Zhou <zhoubb.aaron@...il.com>,
        devicetree@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v4 3/5] dt-bindings: interrupt-controller:
 loongson,liointc: Fix dtbs_check warning for interrupt-names


On Mon, 13 Nov 2023 10:36:45 +0800, Binbin Zhou wrote:
> The Loongson-2K0500/2K1000 CPUs have 64 interrupt sources as inputs, and
> a route-mapped node handles up to 32 interrupt sources, so two liointc
> nodes are defined in dts{i}.
> 
> Of course, we have to make sure that the routing outputs ("intx") of the
> two nodes do not conflict, i.e. "int0" can only be used as a routing
> output for one of them. Therefore, "interrupt-names" should be defined
> as "pattern".
> 
> In addition, since "interrupt-names" and "interrupts" are one-to-one
> correspondence, we pass it to get the corresponding interrupt number in
> the driver. Setting it to "required" does not break ABI, because it
> is already logically represented as "required".
> 
> This fixes dtbs_check warning:
> 
> DTC_CHK arch/loongarch/boot/dts/loongson-2k0500-ref.dtb
> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@...11440: interrupt-names:0: 'int0' was expected
>         From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@...11440: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
>         From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> DTC_CHK arch/loongarch/boot/dts/loongson-2k1000-ref.dtb
> arch/loongarch/boot/dts/loongson-2k1000-ref.dtb: interrupt-controller@...01440: interrupt-names:0: 'int0' was expected
>         From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> arch/loongarch/boot/dts/loongson-2k1000-ref.dtb: interrupt-controller@...01440: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
>         From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> 
> Acked-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> Signed-off-by: Binbin Zhou <zhoubinbin@...ngson.cn>
> ---
>  .../bindings/interrupt-controller/loongson,liointc.yaml    | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>