linux-kernel - Re: [PATCH] docs: dt-bindings: add DTS Coding Style document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f58fae1-6348-4396-b099-1d9517227e86@linaro.org>
Date:   Sat, 18 Nov 2023 00:55:01 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Arnd Bergmann <arnd@...db.de>,
        Bjorn Andersson <andersson@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Heiko Stuebner <heiko@...ech.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Michal Simek <michal.simek@....com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Nishanth Menon <nm@...com>, Olof Johansson <olof@...om.net>
Subject: Re: [PATCH] docs: dt-bindings: add DTS Coding Style document

On 16.11.2023 21:44, Rob Herring wrote:
> On Thu, Nov 16, 2023 at 12:12 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among all (sub)architectures and ease in reviews.
> 
> Thanks for doing this.
> 
>>
>> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Bjorn Andersson <andersson@...nel.org>
>> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Konrad Dybcio <konrad.dybcio@...aro.org>
>> Cc: Matthias Brugger <matthias.bgg@...il.com>
>> Cc: Michal Simek <michal.simek@....com>
>> Cc: Neil Armstrong <neil.armstrong@...aro.org>
>> Cc: Nishanth Menon <nm@...com>
>> Cc: Olof Johansson <olof@...om.net>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> ---
[...]

>> +Example::
>> +
>> +       thermal-sensor@...1000 {
>> +               compatible = "qcom,sm8550-tsens", "qcom,tsens-v2";
>> +               reg = <0x0 0x0c271000 0x0 0x1000>,
>> +                     <0x0 0x0c222000 0x0 0x1000>;
> 
> You should cover the <> style too, meaning <> around each logical entry.
FWIW this matters because e.g.

https://github.com/devicetree-org/devicetree-specification/issues/66

Konrad