[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231117074816.GB10361@thinkpad>
Date: Fri, 17 Nov 2023 13:18:16 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
Serge Semin <fancer.lancer@...il.com>,
Vinod Koul <vkoul@...nel.org>,
Cai Huoqing <cai.huoqing@...ux.dev>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
Herve Codina <herve.codina@...tlin.com>
Subject: Re: [PATCH v5 2/6] dmaengine: dw-edma: Fix wrong interrupt bit set
On Tue, Nov 14, 2023 at 03:51:55PM +0100, Kory Maincent wrote:
Subject should reflect HDMA:
"dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA"
> Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
> bit is already set in the same line.
>
How about:
"Instead of setting HDMA_V0_LOCAL_ABORT_INT_EN bit, HDMA_V0_LOCAL_STOP_INT_EN
bit got set twice, due to which the abort interrupt is not getting generated for
HDMA. Fix it by setting the correct interrupt enable bit."
> Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
With the above changes,
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
- Mani
> Reviewed-by: Serge Semin <fancer.lancer@...il.com>
> ---
>
> Changes in v3:
> - Split the patch in two to differ bug fix and simple harmless typo.
> ---
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index 1f4cb7db5475..108f9127aaaa 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -236,7 +236,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
> /* Interrupt enable&unmask - done, abort */
> tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) |
> HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK |
> - HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN;
> + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;
> SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);
> /* Channel control */
> SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);
>
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists