linux-kernel - Re: [PATCH] drm/ili9163: Add "1.8-128160EF" to spi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87fs1424d4.fsf@minerva.mail-host-address-is-not-set>
Date:   Fri, 17 Nov 2023 09:03:51 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Mostafa Weshahy <mweshahy@...oo.com>,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
        noralf@...nnes.org, mweshahy@...oo.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        daniel@...que.org
Subject: Re: [PATCH] drm/ili9163: Add "1.8-128160EF" to spi_device_id table

Mostafa Weshahy <mweshahy@...oo.com> writes:

Hello Mostafa,

> drm/ili9163: Add "1.8-128160EF" to spi_device_id table
>
> Currently enabling CONFIG_TINYDRM_ILI9163 driver - regardless of the device
> tree - results in the below confusing log line:
> SPI driver ili9163 has no spi_device_id for newhaven,1.8-128160EF
>
> This commit fixes this false alarm by adding "1.8-128160EF" to
> spi_device_id table of ili9163 driver.
>

It's not actually a false alarm, this is needed if you want the driver
module to be automatically loaded. Because the SPI core always reports
a MODALIAS of the form "spi:1.8-128160EF" even if the device has been
registered by OF.

So this is an actual fix since this driver can be built as a module.

> Signed-off-by: Mostafa Weshahy <mweshahy@...oo.com>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat