linux-kernel - Re: [PATCH] crypto: sa2ul - Add check for crypto_aead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2023 18:29:00 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Chen Ni <nichen@...as.ac.cn>
Cc:     davem@...emloft.net, t-kristo@...com, j-keerthy@...com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        nichen@...as.ac.cn
Subject: Re: [PATCH] crypto: sa2ul - Add check for crypto_aead_setkey

Chen Ni <nichen@...as.ac.cn> wrote:
> Add check for crypto_aead_setkey() and return the error if it fails
> in order to transfer the error.
> 
> Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
> drivers/crypto/sa2ul.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
> index 6846a8429574..6bac2382e261 100644
> --- a/drivers/crypto/sa2ul.c
> +++ b/drivers/crypto/sa2ul.c
> @@ -1806,6 +1806,7 @@ static int sa_aead_setkey(struct crypto_aead *authenc,
>        int cmdl_len;
>        struct sa_cmdl_cfg cfg;
>        int key_idx;
> +       int error;
> 
>        if (crypto_authenc_extractkeys(&keys, key, keylen) != 0)
>                return -EINVAL;
> @@ -1869,7 +1870,9 @@ static int sa_aead_setkey(struct crypto_aead *authenc,
>        crypto_aead_set_flags(ctx->fallback.aead,
>                              crypto_aead_get_flags(authenc) &
>                              CRYPTO_TFM_REQ_MASK);
> -       crypto_aead_setkey(ctx->fallback.aead, key, keylen);
> +       error = crypto_aead_setkey(ctx->fallback.aead, key, keylen);
> +       if (error)
> +               return error;

This should be

	return crypto_aead_setkey(ctx->fallback.aead, key, keylen);

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt