linux-kernel - Re: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9cac494-08df-4a0d-9071-b91b04622052@linaro.org>
Date:   Fri, 17 Nov 2023 11:32:57 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tengfei Fan <quic_tengfan@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        tglx@...utronix.de
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, -cc=kernel@...cinc.com
Subject: Re: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume
 and Power buttons

On 17/11/2023 11:18, Tengfei Fan wrote:
> The Volume Down & Power buttons are controlled by the PMIC via the PON
> hardware, and the Volume Up is connected to a PMIC gpio.
> 
> Enable the necessary hardware and setup the GPIO state for the Volume Up
> gpio key.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
> ---

No, really, necessary hardware? So why it is missing in the previous patch?

Stop useless splitting of work which is done. You cannot have "release
late, release often". The rule is: "release early, release often".

NAK.

Best regards,
Krzysztof