linux-kernel - Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVdB7ZyjLay61mLp@gondor.apana.org.au>
Date:   Fri, 17 Nov 2023 18:35:25 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     LeoLiu-oc <LeoLiu-oc@...oxin.com>
Cc:     olivia@...enic.com, martin@...ser.cx, jiajie.ho@...rfivetech.com,
        jenny.zhang@...rfivetech.com, mmyangfl@...il.com, robh@...nel.org,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        CobeChen@...oxin.com, TonyWWang@...oxin.com, YunShen@...oxin.com,
        LeoLiu@...oxin.com
Subject: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore
 instruction

On Wed, Nov 08, 2023 at 03:34:54PM +0800, LeoLiu-oc wrote:
> From: LeoLiuoc <LeoLiu-oc@...oxin.com>
> 
> Add support for Zhaoxin hardware random number generator.
> This driver base on rep_xstore instruction and uses the same
> X86_FEATURE_XSTORE as via-rng driver. Therefore, modify the x86_cpu_id
> array in the via-rng driver, so that the corresponding driver can be
> correctly loader on respective platforms.
> 
> ---
> 
> v1 -> v2:
> 1. Fix assembler code errors
> 2. Remove redundant CPU model check codes
> 
> Signed-off-by: LeoLiuoc <LeoLiu-oc@...oxin.com>
> ---
>  drivers/char/hw_random/Kconfig       | 13 ++++
>  drivers/char/hw_random/Makefile      |  1 +
>  drivers/char/hw_random/via-rng.c     | 23 +++----
>  drivers/char/hw_random/zhaoxin-rng.c | 95 ++++++++++++++++++++++++++++
>  4 files changed, 119 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/char/hw_random/zhaoxin-rng.c

Please cc x86@...r.kernel.org as the same comments to the other
zhaoxin driver seems to be applicable here.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt