linux-kernel - Re: [PATCH V12 20/23] mmc: sdhci-uhs2: add add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK00qKBWv4=gnmULgHg-McOPgwqKp2eTPtW3vD6+dnyF_iAH9Q@mail.gmail.com>
Date:   Fri, 17 Nov 2023 18:50:19 +0800
From:   Victor Shih <victorshihgli@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     adrian.hunter@...el.com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, benchuanggli@...il.com,
        HL.Liu@...esyslogic.com.tw, Greg.tu@...esyslogic.com.tw,
        takahiro.akashi@...aro.org, dlunev@...omium.org,
        Ben Chuang <ben.chuang@...esyslogic.com.tw>,
        Victor Shih <victor.shih@...esyslogic.com.tw>
Subject: Re: [PATCH V12 20/23] mmc: sdhci-uhs2: add add_host() and others to
 set up the driver

On Thu, Oct 5, 2023 at 7:39 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Fri, 15 Sept 2023 at 11:44, Victor Shih <victorshihgli@...il.com> wrote:
> >
> > From: Victor Shih <victor.shih@...esyslogic.com.tw>
> >
> > This is a UHS-II version of sdhci's add_host/remove_host operation.
> > Any sdhci drivers which are capable of handling UHS-II cards must
> > call those functions instead of the corresponding sdhci's.
> >
> > Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
> > Signed-off-by: Victor Shih <victor.shih@...esyslogic.com.tw>
> > Acked-by: Adrian Hunter <adrian.hunter@...el.com>
>
> [...]
>
> Just a few nitpicks, see below.
>
> > +static void __sdhci_uhs2_add_host_v4(struct sdhci_host *host, u32 caps1)
> > +{
> > +       struct mmc_host *mmc;
> > +       u32 max_current_caps2;
> > +
> > +       mmc = host->mmc;
> > +
> > +       /* Support UHS2 */
> > +       if (caps1 & SDHCI_SUPPORT_UHS2)
> > +               mmc->caps2 |= MMC_CAP2_SD_UHS2;
> > +
> > +       max_current_caps2 = sdhci_readl(host, SDHCI_MAX_CURRENT_1);
> > +
> > +       if ((caps1 & SDHCI_CAN_VDD2_180) &&
> > +           !max_current_caps2 &&
> > +           !IS_ERR(mmc->supply.vmmc2)) {
> > +               /* UHS2 - VDD2 */
> > +               int curr = regulator_get_current_limit(mmc->supply.vmmc2);
>
> As I also stated in another reply, please use vqmmc2 instead, which we
> added in patch4.
>

Hi, Ulf

I will update this in version 13.

Thanks, Victor Shih

> > +
> > +               if (curr > 0) {
> > +                       /* convert to SDHCI_MAX_CURRENT format */
> > +                       curr = curr / 1000;  /* convert to mA */
> > +                       curr = curr / SDHCI_MAX_CURRENT_MULTIPLIER;
> > +                       curr = min_t(u32, curr, SDHCI_MAX_CURRENT_LIMIT);
> > +                       max_current_caps2 = curr;
> > +               }
> > +       }
> > +
> > +       if (!(caps1 & SDHCI_CAN_VDD2_180))
> > +               mmc->caps2 &= ~MMC_CAP2_SD_UHS2;
> > +}
> > +
> > +static int sdhci_uhs2_host_ops_init(struct sdhci_host *host);
>
> Please try to re-order the code so this declaration isn't needed.
>

Hi, Ulf

I will update this in version 13.

Thanks, Victor Shih

> > +
> > +static void __sdhci_uhs2_remove_host(struct sdhci_host *host, int dead)
> > +{
> > +       if (!sdhci_uhs2_mode(host))
> > +               return;
> > +
> > +       if (!dead)
> > +               sdhci_uhs2_reset(host, SDHCI_UHS2_SW_RESET_FULL);
> > +}
> > +
>
> [...]
>
> Kind regards
> Uffe