linux-kernel - Re: [PATCH] checkpatch: do not require an empty line before error injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1868fc850a1ea5e51c833b68aacce120ad738ab7.camel@perches.com>
Date:   Thu, 16 Nov 2023 17:46:46 -0800
From:   Joe Perches <joe@...ches.com>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andy Whitcroft <apw@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: do not require an empty line before error
 injection

On Thu, 2023-11-09 at 16:51 +0900, Sergey Senozhatsky wrote:
> ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately
> follow a function it annotates.
> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>

Acked-by: Joe Perches <joe@...ches.com>

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 25fdb7fda112..a94ed6c46a6d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4054,7 +4054,7 @@ sub process {
>  		if ($prevline =~ /^[\+ ]};?\s*$/ &&
>  		    $line =~ /^\+/ &&
>  		    !($line =~ /^\+\s*$/ ||
> -		      $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
> +		      $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ ||
>  		      $line =~ /^\+\s*MODULE_/i ||
>  		      $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
>  		      $line =~ /^\+[a-z_]*init/ ||