linux-kernel - Re: [syzbot] [kernel?] inconsistent lock state in ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231117123148.GA6728@redhat.com>
Date:   Fri, 17 Nov 2023 13:32:22 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     syzbot <syzbot+cbb25bb9b4d29a773985@...kaller.appspotmail.com>,
        boqun.feng@...il.com, brauner@...nel.org,
        linux-kernel@...r.kernel.org, longman@...hat.com,
        michael.christie@...cle.com, mingo@...hat.com, mst@...hat.com,
        syzkaller-bugs@...glegroups.com, tglx@...utronix.de,
        wander@...hat.com, will@...nel.org
Subject: Re: [syzbot] [kernel?] inconsistent lock state in ptrace_attach

On 11/17, Peter Zijlstra wrote:
>
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -461,7 +461,7 @@ static int ptrace_attach(struct task_str
>  				return retval;
>  		}
>
> -		scoped_guard (write_lock, &tasklist_lock) {
> +		scoped_guard (write_lock_irq, &tasklist_lock) {

FWIW,

Acked-by: Oleg Nesterov <oleg@...hat.com>