linux-kernel - [PATCH v4] mtd: rawnand: Increment IFC_TIMEOUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Nov 2023 18:31:51 +1000
From:   Ronald Monthero <debug.penguin32@...il.com>
To:     miquel.raynal@...tlin.com, andriy.shevchenko@...ux.intel.com
Cc:     richard@....at, vigneshr@...com, heiko@...ech.de,
        martin.blumenstingl@...glemail.com, paul@...pouillou.net,
        robh@...nel.org, u.kleine-koenig@...gutronix.de,
        debug.penguin32@...il.com, AVKrasnov@...rdevices.ru,
        r.czerwinski@...gutronix.de, jaimeliao.tw@...il.com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Roger Quadros <rogerq@...nel.org>,
        Tudor Ambarus <tudor.ambarus@...aro.org>,
        Poonam Aggrwal <poonam.aggrwal@...escale.com>,
        Dipen Dudhat <Dipen.Dudhat@...escale.com>,
        Kumar Gala <galak@...nel.crashing.org>,
        Li Yang <leoyang.li@....com>, Liu Shuo <b35362@...escale.com>
Subject: [PATCH v4] mtd: rawnand: Increment IFC_TIMEOUT_MSECS for nand controller response

Under heavy load it is likely that the controller is done
with its own task but the thread unlocking the wait is not
scheduled in time. Increasing IFC_TIMEOUT_MSECS allows the
controller to respond within allowable timeslice of 1 sec.

fsl,ifc-nand 7e800000.nand: Controller is not responding

[<804b2047>] (nand_get_device) from [<804b5335>] (nand_write_oob+0x1b/0x4a)
[<804b5335>] (nand_write_oob) from [<804a3585>] (mtd_write+0x41/0x5c)
[<804a3585>] (mtd_write) from [<804c1d47>] (ubi_io_write+0x17f/0x22c)
[<804c1d47>] (ubi_io_write) from [<804c047b>] (ubi_eba_write_leb+0x5b/0x1d0)

Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller")
Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Signed-off-by: Ronald Monthero <debug.penguin32@...il.com>
---
 drivers/mtd/nand/raw/fsl_ifc_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c b/drivers/mtd/nand/raw/fsl_ifc_nand.c
index 20bb1e0cb5eb..f0e2318ce088 100644
--- a/drivers/mtd/nand/raw/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/raw/fsl_ifc_nand.c
@@ -21,7 +21,7 @@
 
 #define ERR_BYTE		0xFF /* Value returned for read
 					bytes when read failed	*/
-#define IFC_TIMEOUT_MSECS	500  /* Maximum number of mSecs to wait
+#define IFC_TIMEOUT_MSECS	1000 /* Maximum timeout to wait
 					for IFC NAND Machine	*/
 
 struct fsl_ifc_ctrl;
-- 
2.34.1