linux-kernel - Re: [PATCH v4 6/7] media: qcom: camss: Flag VFE-lites to support more VFEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d62238aa-5f1a-4afd-97fe-1f2e1c5d98c6@linaro.org>
Date:   Sat, 18 Nov 2023 01:41:21 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        hverkuil-cisco@...all.nl, laurent.pinchart@...asonboard.com,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        matti.lehtimaki@...il.com, quic_grosikop@...cinc.com
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/7] media: qcom: camss: Flag VFE-lites to support more
 VFEs

On 3.11.2023 13:29, Bryan O'Donoghue wrote:
> From: Matti Lehtimäki <matti.lehtimaki@...il.com>
> 
> Some platforms such as SC7280 have three VFEs and two VFE-lites. Current
> code has hard-coded two as the maximum number of VFEs. Remove the
> hard-coded maximum number of VFEs to handle all possible combinations of
> VFEs and VFE-lites.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@...il.com>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
[...]


> +inline bool vfe_is_lite(struct vfe_device *vfe)
> +{
> +	return vfe->camss->res->vfe_res[vfe->id].is_lite;
0_o

something something vfe could use a direct resource pointer

I hope there are no more hidden (esp. using magic literals) users of
this IS_LITE <=> idx > 2 logic, but old code never fails to disappoint

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad