linux-kernel - Re: [PATCH] power: supply: Fix indentation and some other warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 18 Nov 2023 18:45:49 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Charalampos Mitrodimas <charmitro@...teo.net>,
        Sebastian Reichel <sre@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Mario Limonciello <mario.limonciello@....com>,
        qinyu <qinyu32@...wei.com>, Nick Alcock <nick.alcock@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Andreas Kemnade <andreas@...nade.info>,
        Ian Molton <spyro@....com>,
        Szabolcs Gyurko <szabolcs.gyurko@....hu>,
        Anton Vorontsov <cbou@...l.ru>
Cc:     Linux Power Management <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: supply: Fix indentation and some other warnings

On 11/18/23 17:36, Charalampos Mitrodimas wrote:
> Hi Bagas,
> 
> On Sat Nov 18, 2023 at 1:36 AM EET, Bagas Sanjaya wrote:
>> On Fri, Nov 17, 2023 at 11:06:58PM +0000, Charalampos Mitrodimas wrote:
>>> These were mentioned by checkpatch:
>>> 	Errors:
>>> 		(1) code indent should use tabs where possible
>>> 		(2) switch and case should be at the same indent
>>> 	Warnings:
>>> 		(1) quoted string split across lines
>>> 		(2) Missing a blank line after declarations
>>>
>>> Based on this comment from "include/linux/module.h", modules with
>>> multiple authors should use multiple MODULE_AUTHOR() statements.
>>> 	/*
>>> 	 * Author(s), use "Name <email>" or just "Name", for multiple
>>> 	 * authors use multiple MODULE_AUTHOR() statements/lines.
>>> 	 */
>>> 	#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
>>
>> Shouldn't MODULE_AUTHOR fix be separate patch?
> 
> Sorry, I should have mentioned in the commit that the warnings "quoted
> string split across lines" pertained to the MODULE_AUTHOR line. 
> 
> In the commit message I'm just clarifying why I used multiple
> MODULE_AUTHOR statements.
> 
> Should I send a v2 patch with a revised commit description?
> 

OK but as separate patch.

-- 
An old man doll... just what I always wanted! - Clara