linux-kernel - Re: [PATCH v2 09/15] staging: vc04_services: Add helpers for vchiq driver data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a51d89c-a1d5-4d70-a578-8e8be39152f1@gmx.net>
Date:   Sat, 18 Nov 2023 15:43:15 +0100
From:   Stefan Wahren <wahrenst@....net>
To:     Umang Jain <umang.jain@...asonboard.com>,
        linux-media@...r.kernel.org, kernel-list@...pberrypi.com,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev
Cc:     Dave Stevenson <dave.stevenson@...pberrypi.com>,
        Kieran Bingham <kieran.bingham@...asonboard.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        "Ricardo B . Marliere" <ricardo@...liere.net>,
        Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH v2 09/15] staging: vc04_services: Add helpers for vchiq
 driver data

Hi Umang,

Am 09.11.23 um 22:03 schrieb Umang Jain:
> Add helpers to set and get vchiq driver data.
> vchiq_set_drvdata() and vchiq_get_drvdata() wraps
> dev_set_drvdata() and dev_get_drvdata() respectively.

no strong opinion here, but is this change a real benefit?

Except of this such a change should make use of it.

>
> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>
> ---
>   .../vc04_services/interface/vchiq_arm/vchiq_bus.h      | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h
> index caa6fdf25bb1..800f53bb48c2 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h
> @@ -34,6 +34,16 @@ static inline struct vchiq_driver *to_vchiq_driver(struct device_driver *d)
>   	return container_of(d, struct vchiq_driver, driver);
>   }
>
> +static inline void *vchiq_get_drvdata(const struct vchiq_device *device)
> +{
> +        return dev_get_drvdata(&device->dev);
> +}
> +
> +static inline void vchiq_set_drvdata(struct vchiq_device *device, void *data)
> +{
> +        dev_set_drvdata(&device->dev, data);
> +}
> +
>   extern struct bus_type vchiq_bus_type;
>
>   struct vchiq_device *