linux-kernel - Re: [PATCH v4 2/3] arm64: dts: qcom: Add base qcm6490 idp board dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93c5d2ad-02b2-425b-877b-9576318fe51e@linaro.org>
Date:   Sat, 18 Nov 2023 02:11:37 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Komal Bajaj <quic_kbajaj@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: Add base qcm6490 idp board dts

On 17.11.2023 13:50, Komal Bajaj wrote:
> Add DTS for Qualcomm IDP platform using QCM6490 SoC.
> This adds debug uart, eMMC and usb support along with
> regulators found on this board.
> 
> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
> ---
[...]
 
> +	gpio-reserved-ranges = <32 2>, <48 4>;
Please describe what these pins are for, so e.g.:

gpio-reserved-ranges = <32 2>, /* spaghetti cooker */
		       <48 4>; /* fingerprint scanner */

aside from that, LGTM

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad