linux-kernel - Re: [PATCH 2/4] rtc: Adjust failure return code for cmos_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2017142e-b4aa-4d4c-9673-17533da86826@o2.pl>
Date:   Sat, 18 Nov 2023 19:55:38 +0100
From:   Mateusz Jończyk <mat.jonczyk@...pl>
To:     Mario Limonciello <mario.limonciello@....com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org, tobrohl@...il.com, aalsing@...il.com,
        Dhaval.Giani@....com, xmb8dsv4@...il.com, x86@...nel.org
Subject: Re: [PATCH 2/4] rtc: Adjust failure return code for cmos_set_alarm()

W dniu 17.11.2023 o 07:32, Mario Limonciello pisze:
> When mc146818_avoid_UIP() fails to return a valid value, this is because
> UIP didn't clear in the timeout period. Adjust the return code in this
> case to -ETIMEDOUT.
>
Hello,

Thank you for posting this good patch series.

Why don't you CC stable it?

Fixes: cdedc45c579fa ("rtc: cmos: avoid UIP when reading alarm time")
Fixes: cd17420ebea58 ("rtc: cmos: avoid UIP when writing alarm time")

> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/rtc/rtc-cmos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 228fb2d11c70..b39890a5531e 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -557,7 +557,7 @@ static int cmos_set_alarm(struct device *dev, struct rtc_wkalrm *t)
>  	 * Use mc146818_avoid_UIP() to avoid this.
>  	 */
>  	if (!mc146818_avoid_UIP(cmos_set_alarm_callback, &p))
> -		return -EIO;
> +		return -ETIMEDOUT;
>  
>  	cmos->alarm_expires = rtc_tm_to_time64(&t->time);

This should be changed also in cmos_read_alarm().

Greetings,

Mateusz