linux-kernel - RE: [RFC PATCH] ASoC: simple-card: Use dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYCPR01MB10914A8D3BA6BC9387EC2DC3CD4B5A@TYCPR01MB10914.jpnprd01.prod.outlook.com>
Date:   Sun, 19 Nov 2023 23:28:53 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Daniel Baluta <daniel.baluta@....nxp.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "daniel.baluta@...il.com" <daniel.baluta@...il.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iuliana.prodan@....com" <iuliana.prodan@....com>,
        "shengjiu.wang@....com" <shengjiu.wang@....com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: RE: [RFC PATCH] ASoC: simple-card: Use dai_id from node description

Hi Daniel

Thank you for your patch.

> We can specify DAI id using reg property. When dts
> node has only 1 DAI simple-card always assumes that DAI id is 0.
> 
> But this is not correct in the case of SOF for example which adds DAIs
> staticaly (See definition of snd_soc_dai_driver in sound/soc/sof/imx/imx8m.c)
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> ---
(snip)
> -	args.args_count	= (of_graph_get_endpoint_count(node) > 1);
> +	args.args_count	= (of_graph_get_endpoint_count(node) >= 1);

Hmm... I'm not sure how it works for existing drivers.
I'm busy this week, so I will check it next week.

Thanks