linux-kernel - [PATCH] Tried removing the error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20231119065553.130111-1-tintinm2017@gmail.com>
Date:   Sun, 19 Nov 2023 12:25:54 +0530
From:   attreyee-muk <tintinm2017@...il.com>
To:     maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
        syzbot+ef3256a360c02207a4cb@...kaller.appspotmail.com
Cc:     attreyee-muk <tintinm2017@...il.com>,
        syzkaller-bugs@...glegroups.com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] Tried removing the error

Respected maintainers, 

Looking at the code and the call trace reported by Syzbot, I understood
that the issue lies in the drm_gem.c file in
drm_gem_object_handle_put_unlocked(obj);. As per my understanding, I
believe that a warning is given out when the DRM GEM object handle gets
destroyed along with the function getting returned immediately. To take
care of the warning only, I think that the WARN_ON can be removed with
only the function getting returned when the object handle gets
destroyed, without a warning. Or else, we can even have a message
logging in the place of a direct warning which will give out the
information that the object handle has been destroyed. I also think that
the WARN_ON is given for debugging purposes and hence proposing a
solution if the warning can be replaced with a simple message log.

I am looking forward to getting help in this regard from the respected maintainers. 

Thank You
Attreyee Mukherjee

Signed-off-by: attreyee-muk <tintinm2017@...il.com>
---
 drivers/gpu/drm/drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 44a948b80ee1..b6be9400cd11 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,7 +222,7 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
 	struct drm_device *dev = obj->dev;
 	bool final = false;

-	if (WARN_ON(READ_ONCE(obj->handle_count) == 0))
+	if (READ_ONCE(obj->handle_count) == 0)
 		return;

 	/*
-- 
2.34.1