linux-kernel - Re: drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused variable 'qcom_scm_qseecom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <220a0b53-14eb-445a-9232-f8df314a29bf@kernel.org>
Date:   Mon, 20 Nov 2023 19:51:52 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Maximilian Luz <luzmaximilian@...il.com>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     llvm@...ts.linux.dev,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused
 variable 'qcom_scm_qseecom_allowlist'

On 20/11/2023 19:19, Maximilian Luz wrote:
> 
> 
> On 11/19/23 10:13, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   037266a5f7239ead1530266f7d7af153d2a867fa
>> commit: bdac188ec3c71800dd8419620224ee74ef37732a firmware: qcom: move Qualcomm code into its own directory
>> date:   4 weeks ago
>> config: s390-randconfig-002-20231119 (https://download.01.org/0day-ci/archive/20231119/202311191654.S4wlVUrz-lkp@intel.com/config)
>> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231119/202311191654.S4wlVUrz-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202311191654.S4wlVUrz-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
> 
> [...]
> 
>>>> drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused variable 'qcom_scm_qseecom_allowlist' [-Wunused-const-variable]
>>      1652 | static const struct of_device_id qcom_scm_qseecom_allowlist[] = {
>>           |                                  ^
> 
> Any ideas why this is supposedly unused? It should be accessed through
> qcom_scm_qseecom_init() and qcom_scm_qseecom_machine_is_allowed().
> Especially if CONFIG_QCOM_QSEECOM=y.

And in other cases? The bot reports specific failure on specific config.
You have the config for this arch attached, so you can investigate.

Anyway, short look at the code indeed tells it is unused. It's not
referenced anywhere except of_match_node(). I can fix this.

Best regards,
Krzysztof