linux-kernel - Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0aa142c8-c1cb-df6a-b5fd-6470c95bcef9@quicinc.com>
Date:   Mon, 20 Nov 2023 12:22:46 +0530
From:   Sibi Sankar <quic_sibis@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <andersson@...nel.org>, <ulf.hansson@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>
CC:     <agross@...nel.org>, <conor+dt@...nel.org>,
        <quic_rjendra@...cinc.com>, <abel.vesa@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <quic_tsoni@...cinc.com>, <neil.armstrong@...aro.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to
 X1E80100



On 11/18/23 05:10, Konrad Dybcio wrote:
> On 17.11.2023 13:39, Krzysztof Kozlowski wrote:
>> On 17/11/2023 12:46, Sibi Sankar wrote:
>>> Hey Krzysztof,
>>>
>>> Thanks for taking time to review the series.
>>>
>>> On 11/17/23 16:35, Krzysztof Kozlowski wrote:
>>>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>>>> Replace SC8380xp with the updated part number (X1E80100).
>>>>>
>>>>
>>>> You need to explain why. We don't update compatibles based on marketing
>>>> wishes.
>>>
>>> What we imply is that X1E80100 is the part number you would get when you
>>> read out from a Snapdragon X Elite device in the wild, when it is
>>> available and we didn't have this information when we posted out v1.
>>
>> The commit msg must explain why.
> (what Krzysztof meant is that your explanation is ok but it needs to be
> part of the commit message and not just a reply here)
> 
> Moreover, it would also be good to say something like "this binding has
> no users and has been erroneusly introduced very recently, so it was
> decided that changing it is okay", as this is a rather special case.

Thanks, was going to do the same.

-Sibi

> 
> Konrad