linux-kernel - Re: [PATCH] toos:leds: Fix printf format string in uledmon.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWvnEaNSMRRNEF1ijX_AcuP-AM0rfPnRZ9kr7iYeKzeTA@mail.gmail.com>
Date:   Mon, 20 Nov 2023 14:57:26 -0800
From:   Ian Rogers <irogers@...gle.com>
To:     zhujun2 <zhujun2@...s.chinamobile.com>, david@...hnology.com
Cc:     acme@...nel.org, ast@...nel.org, namhyung@...nel.org,
        kuba@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] toos:leds: Fix printf format string in uledmon.c

Nit in the subject: toos:leds: -> tools/leds:

On Tue, Nov 14, 2023 at 11:11 PM zhujun2 <zhujun2@...s.chinamobile.com> wrote:
>
> When the argument type is 'int',printf '%d'
> in format string.Problem found during code reading.
>
> Signed-off-by: zhujun2 <zhujun2@...s.chinamobile.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/leds/uledmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/leds/uledmon.c b/tools/leds/uledmon.c
> index c15a39c1f271..62befe06eab5 100644
> --- a/tools/leds/uledmon.c
> +++ b/tools/leds/uledmon.c
> @@ -55,7 +55,7 @@ int main(int argc, char const *argv[])
>                         return 1;
>                 }
>                 clock_gettime(CLOCK_MONOTONIC, &ts);
> -               printf("[%ld.%09ld] %u\n", ts.tv_sec, ts.tv_nsec, brightness);
> +               printf("[%ld.%09ld] %d\n", ts.tv_sec, ts.tv_nsec, brightness);
>         }
>
>         close(fd);
> --
> 2.17.1
>
>
>