linux-kernel - Re: [PATCH] nvme-core: remove head->effects to fix use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPpK+O2aitq+ubFRBtjOrUWjdRz=8x3Us9Am4_aVcSo4vAhLYA@mail.gmail.com>
Date:   Mon, 20 Nov 2023 15:31:52 -0800
From:   Randy Jennings <randyj@...estorage.com>
To:     Sagi Grimberg <sagi@...mberg.me>
Cc:     Christoph Hellwig <hch@....de>, Keith Busch <kbusch@...nel.org>,
        Yuanyuan Zhong <yzhong@...estorage.com>,
        Jens Axboe <axboe@...nel.dk>, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, hcoutinho@...estorage.com
Subject: Re: [PATCH] nvme-core: remove head->effects to fix use-after-free

>> It doesn't make sense for effects logs to be different per-controller
>> for the same shared namespace. The spec doesn't seem to explicitly
>> prevent that, but hints that all hosts should be seeing the same thing
>> no matter which controller they're connected to:
>
> Also agreed as already indicated in the past mail.

Yuanyuan Zhong already pointed out a situation where the commands
supported portion of the log page could be different.  When upgrading
the subsystem, some controllers may be upgraded sooner than others.
The upgrade could support new commands.

However, I would be surprised if the effects would be different for
currently supported commands, unless a controller was not reporting
effects before and starts reporting them.

Sincerely,
Randy Jennings