linux-kernel - Re: [PATCH v2] serial: atmel: convert not to use dma_request_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c2ec2ff-459e-4bb7-b287-8a06005c86f5@kernel.org>
Date:   Mon, 20 Nov 2023 08:04:37 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     claudiu beznea <claudiu.beznea@...on.dev>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Richard Genoud <richard.genoud@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] serial: atmel: convert not to use
 dma_request_slave_channel()

On 20. 11. 23, 7:14, claudiu beznea wrote:
> Hi, Christophe,
> 
> On 19.11.2023 17:55, Christophe JAILLET wrote:
>> dma_request_slave_channel() is deprecated. dma_request_chan() should
>> be used directly instead.
>>
>> Switch to the preferred function and update the error handling accordingly.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>> v2: Also update atmel_prepare_rx_dma()
>> ---
>>   drivers/tty/serial/atmel_serial.c | 16 ++++++++++++----
>>   1 file changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
>> index 1946fafc3f3e..6aeb4648843b 100644
>> --- a/drivers/tty/serial/atmel_serial.c
>> +++ b/drivers/tty/serial/atmel_serial.c
>> @@ -1013,14 +1013,18 @@ static int atmel_prepare_tx_dma(struct uart_port *port)
>>   	struct device *mfd_dev = port->dev->parent;
>>   	dma_cap_mask_t		mask;
>>   	struct dma_slave_config config;
>> +	struct dma_chan *chan;
> 
> There is no need for this.

How'd you avoid crash in here then:
         if (atmel_port->chan_tx)
                 atmel_release_tx_dma(port);
?

thanks,
-- 
js
suse labs