[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3b43267d-f458-439b-82dd-03a2771e49be@linaro.org>
Date: Mon, 20 Nov 2023 08:06:33 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Rob Herring <robh@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: PCI: qcom: correct clocks for SC8180x
and SM8150
On 16/11/2023 07:05, Manivannan Sadhasivam wrote:
> On Sun, Nov 12, 2023 at 07:45:57PM +0100, Krzysztof Kozlowski wrote:
>> PCI node in Qualcomm SC8180x DTS has 8 clocks, while one on SM8150 has 7
>> clocks:
>>
>> sc8180x-primus.dtb: pci@...0000: 'oneOf' conditional failed, one must be fixed:
>> ['pipe', 'aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'ref', 'tbu'] is too short
>>
>> sm8150-hdk.dtb: pci@...0000: 'oneOf' conditional failed, one must be fixed:
>> ['pipe', 'aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'ref', 'tbu'] is too short
>
> This error says that SM8150 has 8 clocks defined in DT, but it has only 7. I'm
> confused.
I think I pasted wrong error. I'll fix in v2.
>
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Anyway, the patch looks good to me.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>
Thanks.
Best regards,
Krzysztof
Powered by blists - more mailing lists