linux-kernel - Re: [PATCH v2 2/8] arm64: dts: qcom: add initial SM8650 dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46bcf9fe-d896-4a8d-90da-1f86711fd736@linaro.org>
Date:   Mon, 20 Nov 2023 09:12:49 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] arm64: dts: qcom: add initial SM8650 dtsi

On 18/11/2023 01:21, Konrad Dybcio wrote:
> On 6.11.2023 09:39, Neil Armstrong wrote:
>> Add initial DTSI for the Qualcomm SM8650 platform,
>> only contains nodes which doesn't depend on interconnect.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
> Just a couple nits
> 
> [...]
> 
>> +		cpu2-bottom-thermal {
>> +			polling-delay-passive = <0>;
>> +			polling-delay = <0>;
>> +			thermal-sensors = <&tsens0 6>;
>> +
>> +			trips {
>> +				trip-point0 {
>> +					temperature = <90000>;
>> +					hysteresis = <2000>;
>> +					type = "passive";
>> +				};
>> +
>> +				trip-point1 {
>> +					temperature = <95000>;
>> +					hysteresis = <2000>;
>> +					type = "passive";
>> +				};
>> +
>> +				 cpu-critical {
> indentation
> 
>> +					temperature = <110000>;
>> +					hysteresis = <1000>;
>> +					type = "critical";
>> +				};
>> +			};
>> +		};
> [...]
>> +
>> +		nsphmx-0-thermal {
>> +			polling-delay-passive = <10>;
>> +			polling-delay = <0>;
>> +			thermal-sensors = <&tsens2 8>;
>> +
>> +			trips {
>> +				thermal-engine-config {
>> +					temperature = <125000>;
>> +					hysteresis = <1000>;
>> +					type = "passive";
>> +				};
>> +
>> +				thermal-hal-config {
>> +					temperature = <125000>;
>> +					hysteresis = <1000>;
>> +					type = "passive";
>> +				};
> The two above nodes (which are repeated under many tzones) sound made up
> just to be consumed by a bunch of android binaries
> 
> Or at least the second one, maybe "thermal engine" is some hw/fw part?
> 
>> +
>> +				reset-mon-config {
> "reset mon" is not a very enticing name either..
> 
>> +					temperature = <115000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
>> +				};
>> +
>> +				junction-config {
> ...which leads me to believe only this one is meaningful
> 
> same goes for all tzones that have a similar mess :/
>> +					temperature = <95000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
>> +				};

I already did a big cleanep, will clean even further!

Thx,
Neil

> 
> Konrad