[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231120082346.GA11622@lst.de>
Date: Mon, 20 Nov 2023 09:23:46 +0100
From: Christoph Hellwig <hch@....de>
To: Keith Busch <kbusch@...nel.org>
Cc: Christoph Hellwig <hch@....de>,
Yuanyuan Zhong <yzhong@...estorage.com>,
Jens Axboe <axboe@...nel.dk>, sagi@...mberg.me,
linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
randyj@...estorage.com, hcoutinho@...estorage.com
Subject: Re: [PATCH] nvme-core: remove head->effects to fix use-after-free
On Fri, Nov 17, 2023 at 09:38:19AM -0700, Keith Busch wrote:
> The effects log is per-CSI so different command sets won't create
> conflicts.
True. But that wasn't the point anyway. It is that different
controllers might expose very different namespaes with different
capabilities. Maybe a controller with HDD namespaces vs flash might
be a better example.
> Namespaces that are not shared don't really matter here because this
> problem is unique to mulitpath.
Indeed.
> It doesn't make sense for effects logs to be different per-controller
> for the same shared namespace. The spec doesn't seem to explicitly
> prevent that, but hints that all hosts should be seeing the same thing
> no matter which controller they're connected to:
Also agreed as already indicated in the past mail.
Powered by blists - more mailing lists