linux-kernel - Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'xhci-sg-trb-cache-size-quirk'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caccb6a2-643f-427e-a601-590a1ce88802@kernel.org>
Date:   Mon, 20 Nov 2023 10:14:06 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Prashanth K <quic_prashk@...cinc.com>, stable@...r.kernel.org,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Tejas Joglekar <joglekar@...opsys.com>,
        linux-kernel@...r.kernel.org, linux-usbyy@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add
 'xhci-sg-trb-cache-size-quirk'

On 20/11/2023 06:58, Prashanth K wrote:
> Add a new 'xhci-sg-trb-cache-size-quirk' DT quirk to dwc3 core
> for preventing xhci hang issue while using SG buffers.

Neither commit msg nor property describes the hardware feature. Please
describe the hardware, not OS behavior, in the property. Both in the
property name and in its description.

> 
> Cc: <stable@...r.kernel.org> # 5.11
> Fixes: bac1ec551434 ("usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK")
> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Also, use proper order of patches - first bindings, then their user.

Best regards,
Krzysztof