linux-kernel - Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and imx8mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6322fd4c1967a518310140c35ab34f65@mail.infomaniak.com>
Date:   Mon, 20 Nov 2023 10:33:38 +0100
From:   linux@...ler.io
To:     Francesco Dolcini <francesco@...cini.it>
Cc:     Stefan Moring <stefan.moring@...hnolution.nl>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org
Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and
 imx8mm

Hi Francesco

I run the test and it worked fine. The transmitted data matches with the recived data, no diff.

BUT!!! on the MDIO it is completly different !!!
When I request to send 4kB Data I measure on the line 16384Byte.

The data is again   3Dummy Bytes followed by the databyte.
So the error symetic on send and recive

Regards Stefan

Am 2023-11-20T09:47:48.000+01:00 hat Francesco Dolcini <francesco@...cini.it> geschrieben:
>  On Mon, Nov 20, 2023 at 09:27:10AM +0100, linux@...ler.io wrote:
> 
> >    Load the spi-dma (imx-sdma 302c0000.dma-controller: loaded firmware
> >  4.5), run the spi_imx and the spidev as kenelmodule.
> >  
> >  I run the code on a Toradex Verdin Development Board and use the
> >  imx8mm-verdin-nonwifi-dev.dts
> >  
> >  To add the spidev I patched imx8mm-verdin.dtsi
> >  diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> >  index 6f0811587142..262500940adc 100644
> >  --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> >  +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> >  @@ -209,6 +209,15 @@ &ecspi2 {
> >          cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> >          pinctrl-names = "default";
> >          pinctrl-0 = <&pinctrl_ecspi2>;
> >  +
> >  +       spidev@0{
> >  +               compatible = "micron,spi-authenta";
> >  +               reg = <0>;
> >  +               #address-cells = <1>;
> >  +               #size-cells = <0>;
> >  +               spi-max-frequency = <20000000>;
> >  +               status = "okay";
> >  +       };
> >   };
> >  
> >  as a spidev test program I used 
> >  https://raw.githubusercontent.com/raspberrypi/linux/rpi-3.10.y/Documentation/spi/spidev_test.c
>  
> Would you mind doing the following tests looping the SPI interface MISO/MOSI?
> 
> ```
> cd /tmp
> 
> dd if=/dev/urandom of=4k-spi-test-data.bin bs=1 count=4k
> spidev_test -D "$device" -s 4000000 -i 4k-spi-test-data.bin -o 4k-spi-test-result.bin
> 
> dd if=/dev/urandom of=16bytes-spi-test-data.bin bs=1 count=16
> spidev_test -D "$device" -s 16000 -i 16bytes-spi-test-data.bin -o 16bytes-spi-test-result.bin
> ```
> 
> with "$device" being your actual spidev device?
> 
> Those tests are passing on 6.7.0-rc2 for me.
> 
Francesco