linux-kernel - [PATCH] ksmbd: initialize ar to NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231120023950.667246-1-zhouzongmin@kylinos.cn>
Date:   Mon, 20 Nov 2023 10:39:50 +0800
From:   Zongmin Zhou <zhouzongmin@...inos.cn>
To:     linkinjeon@...nel.org, sfrench@...ba.org
Cc:     senozhatsky@...omium.org, tom@...pey.com,
        linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zongmin Zhou <zhouzongmin@...inos.cn>
Subject: [PATCH] ksmbd: initialize ar to NULL

Initialize ar to NULL to avoid the case of aux_size will be false,
and kfree(ar) without ar been initialized will be unsafe.
But kfree(NULL) is safe.

Signed-off-by: Zongmin Zhou<zhouzongmin@...inos.cn>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>
---
 fs/smb/server/ksmbd_work.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/server/ksmbd_work.c b/fs/smb/server/ksmbd_work.c
index 44bce4c56daf..2510b9f3c8c1 100644
--- a/fs/smb/server/ksmbd_work.c
+++ b/fs/smb/server/ksmbd_work.c
@@ -106,7 +106,7 @@ static inline void __ksmbd_iov_pin(struct ksmbd_work *work, void *ib,
 static int __ksmbd_iov_pin_rsp(struct ksmbd_work *work, void *ib, int len,
 			       void *aux_buf, unsigned int aux_size)
 {
-	struct aux_read *ar;
+	struct aux_read *ar = NULL;
 	int need_iov_cnt = 1;
 
 	if (aux_size) {
-- 
2.34.1