linux-kernel - Re: [PATCH 6/7] ASoC: cs43130: Allow driver to work without IRQ thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153531080cd3d36fea86263d393ef885533f6e44.camel@opensource.cirrus.com>
Date:   Mon, 20 Nov 2023 09:43:25 +0000
From:   Maciej Strozek <mstrozek@...nsource.cirrus.com>
To:     Mark Brown <broonie@...nel.org>
CC:     James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/7] ASoC: cs43130: Allow driver to work without IRQ
 thread

W dniu pią, 17.11.2023 o godzinie 16∶36 +0000, użytkownik Mark Brown
napisał:
> On Fri, Nov 17, 2023 at 02:13:43PM +0000, Maciej Strozek wrote:
> > Signed-off-by: Maciej Strozek <mstrozek@...nsource.cirrus.com>
> > ---
> >  sound/soc/codecs/cs43130.c | 56 +++++++++++++++++++++++++++++++---
> > ----
> >  sound/soc/codecs/cs43130.h |  1 +
> >  2 files changed, 47 insertions(+), 10 deletions(-)
> 
> Why?  This isn't some obvious fix, you need to write a changelog
> motivating open coding interrupt handling if there's some reason for
> doing that.

This is to support systems without physical IRQ connection. The device
only requires the IRQ for a couple of internal delays, this polling
mechanism is a fallback when no IRQ is specified.