linux-kernel - Re: [PATCH v2] autofs: add: new_inode check in autofs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231120-dergleichen-parkverbot-dbfcafdc0c26@brauner>
Date:   Mon, 20 Nov 2023 15:01:55 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Ian Kent <raven@...maw.net>
Cc:     Christian Brauner <brauner@...nel.org>,
        Bill O'Donnell <billodo@...hat.com>,
        Kernel Mailing List <linux-kernel@...r.kernel.org>,
        autofs mailing list <autofs@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        syzbot+662f87a8ef490f45fa64@...kaller.appspotmail.com,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v2] autofs: add: new_inode check in autofs_fill_super()

On Mon, 20 Nov 2023 06:53:19 +0800, Ian Kent wrote:
> Add missing NULL check of root_inode in autofs_fill_super().
> 
> While we are at it simplify the logic by taking advantage of the VFS
> cleanup procedures and get rid of the goto error handling, as suggested
> by Al Viro.
> 
> 
> [...]

I've removed an unused variable. I also changed it so that it errors out
right after autofs_get_inode() returns NULL.

---

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] autofs: add: new_inode check in autofs_fill_super()
      https://git.kernel.org/vfs/vfs/c/368e8258536e