linux-kernel - Re: [PATCH 00/13] x86/CPU/AMD: Rework Zen family detection and other fun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bddf9acc-5ffa-4430-9f5a-6322f31a4dd3@suse.com>
Date:   Mon, 20 Nov 2023 17:08:10 +0200
From:   Nikolay Borisov <nik.borisov@...e.com>
To:     Borislav Petkov <bp@...en8.de>, X86 ML <x86@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/13] x86/CPU/AMD: Rework Zen family detection and other
 fun



On 20.11.23 г. 12:41 ч., Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> 
> Add Zen generation flags which will be used to check on what type of Zen
> the kernel runs. Distribute the per-generation init work into the
> respective functions and cleanup amd.c properly.
> 
> As a result, drop the errata checking gunk which is not needed anymore.
> 
> There should be no functionality change resulting from these changes.
> 
> Borislav Petkov (AMD) (13):
>    x86/CPU/AMD: Add ZenX generations flags
>    x86/CPU/AMD: Carve out the erratum 1386 fix
>    x86/CPU/AMD: Move the Zen3 BTC_NO detection to the Zen3 init function
>    x86/CPU/AMD: Move erratum 1076 fix into the Zen1 init function
>    x86/CPU/AMD: Call the spectral chicken in the Zen2 init function
>    x86/CPU/AMD: Rename init_amd_zn() to init_amd_zen_common()
>    x86/CPU/AMD: Move Zenbleed check to the Zen2 init function
>    x86/CPU/AMD: Move the DIV0 bug detection to the Zen1 init function
>    x86/CPU/AMD: Get rid of amd_erratum_1054[]
>    x86/CPU/AMD: Get rid of amd_erratum_383[]
>    x86/CPU/AMD: Get rid of amd_erratum_400[]
>    x86/CPU/AMD: Get rid of amd_erratum_1485[]
>    x86/CPU/AMD: Drop now unused CPU erratum checking function
> 
>   arch/x86/include/asm/cpufeatures.h |   6 +-
>   arch/x86/kernel/cpu/amd.c          | 266 ++++++++++++++---------------
>   2 files changed, 135 insertions(+), 137 deletions(-)
> 

The whole series LGTM:

Reviewed-by: Nikolay Borisov <nik.borisov@...e.com >