linux-kernel - Re: [PATCH v2] PM: hibernate: Fix the bug where wake events cannot wake system during hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Nov 2023 22:55:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chris Feng <chris.feng@...iatek.com>, rafael@...nel.org,
        pavel@....cz, len.brown@...el.com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...nel.org, hua.yang@...iatek.com, ting.wang@...iatek.com,
        liang.lu@...iatek.com, chetan.kumar@...iatek.com,
        Chris Feng <chris.feng@...iatek.com>
Subject: Re: [PATCH v2] PM: hibernate: Fix the bug where wake events cannot
 wake system during hibernation

Hi Chris,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.7-rc2 next-20231120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chris-Feng/PM-hibernate-Fix-the-bug-where-wake-events-cannot-wake-system-during-hibernation/20231120-161752
base:   linus/master
patch link:    https://lore.kernel.org/r/20231120081516.55172-1-chris.feng%40mediatek.com
patch subject: [PATCH v2] PM: hibernate: Fix the bug where wake events cannot wake system during hibernation
config: arm-randconfig-003-20231120 (https://download.01.org/0day-ci/archive/20231120/202311202258.eqaMpEXc-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311202258.eqaMpEXc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311202258.eqaMpEXc-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/power/hibernate.c:672:4: error: call to undeclared function 'swsusp_unmark'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           swsusp_unmark();
                           ^
   1 error generated.


vim +/swsusp_unmark +672 kernel/power/hibernate.c

   664	
   665		switch (hibernation_mode) {
   666		case HIBERNATION_REBOOT:
   667			kernel_restart(NULL);
   668			break;
   669		case HIBERNATION_PLATFORM:
   670			error = hibernation_platform_enter();
   671			if (error == -EAGAIN || error == -EBUSY) {
 > 672				swsusp_unmark();
   673				events_check_enabled = false;
   674				pr_err("Hibernation Abort.\n");
   675				return;
   676			}
   677			fallthrough;
   678		case HIBERNATION_SHUTDOWN:
   679			if (kernel_can_power_off())
   680				kernel_power_off();
   681			break;
   682		}
   683		kernel_halt();
   684		/*
   685		 * Valid image is on the disk, if we continue we risk serious data
   686		 * corruption after resume.
   687		 */
   688		pr_crit("Power down manually\n");
   689		while (1)
   690			cpu_relax();
   691	}
   692	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki