linux-kernel - RE: [PATCH v13] platform/x86: Add Silicom Platform Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PA4PR04MB92222C42B50F1F088C5AEB569AB4A@PA4PR04MB9222.eurprd04.prod.outlook.com>
Date:   Mon, 20 Nov 2023 15:25:44 +0000
From:   Huibin Shi <henrys@...icom-usa.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Henry Shi <henryshi2018@...il.com>
CC:     "hbshi69@...mail.com" <hbshi69@...mail.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        Hans de Goede <hdegoede@...hat.com>,
        "markgross@...nel.org" <markgross@...nel.org>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        LKML <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "hb_shi2003@...oo.com" <hb_shi2003@...oo.com>,
        Wen Wang <wenw@...icom-usa.com>
Subject: RE: [PATCH v13] platform/x86: Add Silicom Platform Driver

Hi Ilpo,

Thanks for your comments. Regarding your comments:

> +               device. It returns to default value after power cycle.

to default value -> to 0

What actually sets power_cycle variable back to 0? I couldn't find such code.

Also, writing 1 and then 0 to sysfs power_cycle causes reads to return garbage unrelated to the whether there's power cycling currently going on or not.

I think you should first parse the string to local variable in power_cycle_store(), after checking it's okay take the mutex, and only then update power_cycle variable.

Henry: According to hardware design of this board, when powercycle_uc() is called, it will cause the whole platform to go through a hard power cycle. So Linux system will restart and this driver will be re-installed. There is no chance that power_cycle value will be read after powercycle_uc() is called. This is why I did not set "powey_cycle" variable value to 0 explicitly in function power_cycle_store(). Maybe I need add comments to explain this in function power_cycle_store(). Any suggestion on this?

Thanks
Henry