[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2d8c7cc2-2c6c-4539-abf3-81700f27b1a7@linaro.org>
Date: Mon, 20 Nov 2023 17:41:52 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elliot Berman <quic_eberman@...cinc.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Mark Rutland <mark.rutland@....com>
Cc: Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>,
Melody Olvera <quic_molvera@...cinc.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Florian Fainelli <florian.fainelli@...adcom.com>
Subject: Re: [PATCH 2/3] dt-bindings: arm: Document reboot mode magic
On 20/11/2023 16:45, Elliot Berman wrote:
>
>
> On 11/20/2023 2:56 AM, Krzysztof Kozlowski wrote:
>> On 17/11/2023 22:18, Elliot Berman wrote:
>>> -
>>> -additionalProperties: false
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: arm,psci-1.0
>>> + then:
>>> + $ref: /schemas/power/reset/reboot-mode.yaml#
>>> + properties:
>>> + # "mode-normal" is just SYSTEM_RESET
>>> + mode-normal: false
>>> + patternProperties:
>>> + "^mode-.*$":
>>> + maxItems: 2
>>
>> And if you tested the patch, it would tell you it can be max 1 item.
>
> make dt_binding_check DT_SCHEMA_FILES=arm/psci.yaml
psci.example.dtb: psci: mode-edl: [[0]] is too short
psci.example.dtb: psci: mode-bootloader: [[1, 2]] is too short
psci.example.dtb: psci: Unevaluated properties are not allowed
('mode-bootloader', 'mode-edl' were unexpected)
>
> passes for me. Rob explained why it's working (and why it shouldn't),
> so I'll fix it according to his recommendation in v2.
Then you wanted uint32-matrix.
Best regards,
Krzysztof
Powered by blists - more mailing lists