[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231121153302.GD173820@google.com>
Date: Tue, 21 Nov 2023 15:33:02 +0000
From: Lee Jones <lee@...nel.org>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: Pavel Machek <pavel@....cz>,
Patrick Rudolph <patrick.rudolph@...ements.com>,
linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [RESEND PATCH v3] leds: max5970: Add support for max5970
On Mon, 20 Nov 2023, Naresh Solanki wrote:
> Hi
>
> On Fri, 17 Nov 2023 at 17:45, Lee Jones <lee@...nel.org> wrote:
> >
> > On Thu, 09 Nov 2023, Naresh Solanki wrote:
> >
> > > Hey Lee,
> > >
> > > Is there anything specific you'd suggest changing in the current
> > > patchset, or are we good to proceed?
> >
> > What do you mean by proceed?
> >
> > You are good to make changes and submit a subsequent version.
> >
> > Not entirely sure what you're asking.
>
> As a follow up on previous discussion regarding use of DEFER on probe
> if regmap isn't initialized, the implementation was based on other similar
> drivers & hence it was retained although its not needed due to dependencies.
>
> I'm not entirely sure to keep the regmap check or make another
> patch revision with regmap check removed ?
You tell me.
You should understand the device you're attempting to support along with
the code you're authoring and its subsequent implications. If you don't
know what a section of code does or whether/why it's required, why did
you write it?
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists