linux-kernel - Re: [PATCH-cgroup] workqueue: Move workqueue_set_unbound_cpumask() and its helpers inside CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZVzYuHLvWfgIn5qP@slm.duckdns.org>
Date:   Tue, 21 Nov 2023 06:20:08 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Waiman Long <longman@...hat.com>
Cc:     Lai Jiangshan <jiangshanlai@...il.com>, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH-cgroup] workqueue: Move workqueue_set_unbound_cpumask()
 and its helpers inside CONFIG_SYSFS

On Mon, Nov 20, 2023 at 09:18:40PM -0500, Waiman Long wrote:
> Commit fe28f631fa94 ("workqueue: Add workqueue_unbound_exclude_cpumask()
> to exclude CPUs from wq_unbound_cpumask") makes
> workqueue_set_unbound_cpumask() static as it is not used elsewhere in
> the kernel. However, this triggers a kernel test robot warning about
> 'workqueue_set_unbound_cpumask' defined but not used when CONFIG_SYS
> isn't defined. It happens that workqueue_set_unbound_cpumask() is only
> called when CONFIG_SYS is defined.
> 
> Move workqueue_set_unbound_cpumask() and its helpers inside the
> CONFIG_SYSFS compilation block to avoid the warning. There is no
> functional change.
> 
> Fixes: fe28f631fa94 ("workqueue: Add workqueue_unbound_exclude_cpumask() to exclude CPUs from wq_unbound_cpumask")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311130831.uh0AoCd1-lkp@intel.com/
> Signed-off-by: Waiman Long <longman@...hat.com>

Applied to cgroup/for-6.8.

Thanks.

-- 
tejun