linux-kernel - Re: [PATCH 12/34] wifi: intel: use atomic find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVzcdKb1plk/Qose@yury-ThinkPad>
Date:   Tue, 21 Nov 2023 08:36:04 -0800
From:   Yury Norov <yury.norov@...il.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     linux-kernel@...r.kernel.org, Stanislaw Gruszka <stf_xl@...pl>,
        Kalle Valo <kvalo@...nel.org>,
        Gregory Greenman <gregory.greenman@...el.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Miri Korenblit <miriam.rachel.korenblit@...el.com>,
        linux-wireless@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Mirsad Todorovac <mirsad.todorovac@....unizg.hr>,
        Matthew Wilcox <willy@...radead.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
        Alexey Klimov <klimov.linux@...il.com>
Subject: Re: [PATCH 12/34] wifi: intel: use atomic find_bit() API where
 appropriate

On Sun, Nov 19, 2023 at 08:58:25PM +0100, Johannes Berg wrote:
> On Sat, 2023-11-18 at 07:50 -0800, Yury Norov wrote:
> > iwlegacy and iwlwifi code opencodes atomic bit allocation/traversing by
> > using loops. 
> 
> That's really just due to being lazy though, it could use a non-atomic
> __test_and_set_bit() would be just fine in all of this, there's always a
> mutex held around it that protects the data.

Ok, then I'll drop the patch.

> Not that it means that the helper is _wrong_, it's just unnecessary, and
> you don't have non-atomic versions of these, do you?

Not yet. If atomic find_bit() will get merged, and there will be a
set of potential users of non-atomic version, I may need to revisit
it and add those non-atomic functions.

Thanks,
        Yury