| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPLW+4nkrMwc9GiQyn7ojaPz_50NQ3vAcMt9+tOzpHfq7G7+Tg@mail.gmail.com>
Date: Tue, 21 Nov 2023 11:48:29 -0600
From: Sam Protsenko <semen.protsenko@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Andi Shyti <andi.shyti@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Lee Jones <lee@...nel.org>,
Ulf Hansson <ulf.hansson@...aro.org>,
Tomasz Figa <tomasz.figa@...il.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Linus Walleij <linus.walleij@...aro.org>,
Thierry Reding <thierry.reding@...il.com>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Jaehoon Chung <jh80.chung@...sung.com>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-iio@...r.kernel.org, linux-mmc@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-serial@...r.kernel.org,
alsa-devel@...a-project.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 16/17] arm64: dts: exynos850: add specific compatibles to
several blocks
On Wed, Nov 8, 2023 at 4:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Exynos850 reuses several devices from older designs, thus historically
> we kept the old (block's) compatible only. This works fine and there is
> no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to Exynos850 in front of all old-SoC-like
> compatibles. This will also help reviews of new code using existing
> DTS as template. No functional impact on Linux drivers behavior.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@...aro.org>
> arch/arm64/boot/dts/exynos/exynos850.dtsi | 34 +++++++++++++----------
> 1 file changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index 53104e65b9c6..df5ea43ebcad 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> @@ -396,7 +396,7 @@ pinctrl_aud: pinctrl@...60000 {
> };
>
> rtc: rtc@...30000 {
> - compatible = "samsung,s3c6410-rtc";
> + compatible = "samsung,exynos850-rtc", "samsung,s3c6410-rtc";
> reg = <0x11a30000 0x100>;
> interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> @@ -406,7 +406,8 @@ rtc: rtc@...30000 {
> };
>
> mmc_0: mmc@...00000 {
> - compatible = "samsung,exynos7-dw-mshc-smu";
> + compatible = "samsung,exynos850-dw-mshc-smu",
> + "samsung,exynos7-dw-mshc-smu";
> reg = <0x12100000 0x2000>;
> interrupts = <GIC_SPI 452 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -419,7 +420,7 @@ mmc_0: mmc@...00000 {
> };
>
> i2c_0: i2c@...30000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13830000 0x100>;
> interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -432,7 +433,7 @@ i2c_0: i2c@...30000 {
> };
>
> i2c_1: i2c@...40000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13840000 0x100>;
> interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -445,7 +446,7 @@ i2c_1: i2c@...40000 {
> };
>
> i2c_2: i2c@...50000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13850000 0x100>;
> interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -458,7 +459,7 @@ i2c_2: i2c@...50000 {
> };
>
> i2c_3: i2c@...60000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13860000 0x100>;
> interrupts = <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -471,7 +472,7 @@ i2c_3: i2c@...60000 {
> };
>
> i2c_4: i2c@...70000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13870000 0x100>;
> interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -485,7 +486,7 @@ i2c_4: i2c@...70000 {
>
> /* I2C_5 (also called CAM_PMIC_I2C in TRM) */
> i2c_5: i2c@...80000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13880000 0x100>;
> interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -499,7 +500,7 @@ i2c_5: i2c@...80000 {
>
> /* I2C_6 (also called MOTOR_I2C in TRM) */
> i2c_6: i2c@...90000 {
> - compatible = "samsung,s3c2440-i2c";
> + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c";
> reg = <0x13890000 0x100>;
> interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -640,7 +641,8 @@ usi_hsi2c_0: usi@...a00c0 {
> status = "disabled";
>
> hsi2c_0: i2c@...a0000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x138a0000 0xc0>;
> interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -668,7 +670,8 @@ usi_hsi2c_1: usi@...b00c0 {
> status = "disabled";
>
> hsi2c_1: i2c@...b0000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x138b0000 0xc0>;
> interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -696,7 +699,8 @@ usi_hsi2c_2: usi@...c00c0 {
> status = "disabled";
>
> hsi2c_2: i2c@...c0000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x138c0000 0xc0>;
> interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -738,7 +742,8 @@ usi_cmgp0: usi@...000c0 {
> status = "disabled";
>
> hsi2c_3: i2c@...00000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x11d00000 0xc0>;
> interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> @@ -778,7 +783,8 @@ usi_cmgp1: usi@...200c0 {
> status = "disabled";
>
> hsi2c_4: i2c@...20000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x11d20000 0xc0>;
> interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> --
> 2.34.1
>
Powered by blists - more mailing lists