linux-kernel - Re: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202311220129.aOYelwJQ-lkp@intel.com>
Date:   Wed, 22 Nov 2023 01:58:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jingbao Qiu <qiujingbao.dlmu@...il.com>, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, krzysztof.kozlowski+dt@...aro.org,
        chao.wei@...hgo.com, unicorn_wang@...look.com, conor+dt@...nel.org,
        robh+dt@...nel.org, conor@...nel.org, paul.walmsley@...ive.com,
        palmer@...belt.com, aou@...s.berkeley.edu
Cc:     oe-kbuild-all@...ts.linux.dev, linux-rtc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jingbao Qiu <qiujingbao.dlmu@...il.com>
Subject: Re: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B
 SoC

Hi Jingbao,

kernel test robot noticed the following build errors:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linus/master v6.7-rc2 next-20231121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jingbao-Qiu/dt-bindings-rtc-add-binding-for-Sophgo-CV1800B-rtc-controller/20231121-174927
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link:    https://lore.kernel.org/r/20231121094642.2973795-3-qiujingbao.dlmu%40gmail.com
patch subject: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC
config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20231122/202311220129.aOYelwJQ-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/202311220129.aOYelwJQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311220129.aOYelwJQ-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-cv1800b.c: In function 'cv1800b_rtc_probe':
>> drivers/rtc/rtc-cv1800b.c:246:16: error: implicit declaration of function 'rtc_register_device'; did you mean 'devm_rtc_register_device'? [-Werror=implicit-function-declaration]
     246 |         return rtc_register_device(rtc->rtc_dev);
         |                ^~~~~~~~~~~~~~~~~~~
         |                devm_rtc_register_device
   cc1: some warnings being treated as errors


vim +246 drivers/rtc/rtc-cv1800b.c

   189	
   190	static int cv1800b_rtc_probe(struct platform_device *pdev)
   191	{
   192		struct cv1800b_rtc_priv *rtc;
   193		struct resource *res;
   194		int ret;
   195	
   196		rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL);
   197		if (!rtc)
   198			return -ENOMEM;
   199	
   200		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   201		if (!res) {
   202			ret = -ENODEV;
   203			goto err;
   204		}
   205	
   206		rtc->core_map = devm_ioremap_resource(&pdev->dev, res);
   207		if (IS_ERR(rtc->core_map)) {
   208			ret = PTR_ERR(rtc->core_map);
   209			goto err;
   210		}
   211	
   212		rtc->irq = platform_get_irq(pdev, 0);
   213		platform_set_drvdata(pdev, rtc);
   214		if (rtc->irq < 0) {
   215			ret = -EINVAL;
   216			goto err;
   217		}
   218	
   219		ret =
   220		    devm_request_irq(&pdev->dev, rtc->irq, cv1800b_rtc_irq_handler,
   221				     IRQF_SHARED, "rtc alarm", &pdev->dev);
   222		if (ret)
   223			goto err;
   224	
   225		rtc->clk = devm_clk_get(&pdev->dev, NULL);
   226		if (IS_ERR(rtc->clk)) {
   227			dev_err(&pdev->dev, "no clock");
   228			ret = PTR_ERR(rtc->clk);
   229			goto err;
   230		}
   231		ret = clk_prepare_enable(rtc->clk);
   232		if (ret)
   233			goto err;
   234		ret = cv1800b_rtc_softinit(rtc);
   235		if (ret)
   236			goto err;
   237		cv1800b_rtc_alarm_irq_enable(&pdev->dev, 1);
   238		rtc->rtc_dev = devm_rtc_allocate_device(&pdev->dev);
   239		if (IS_ERR(rtc->rtc_dev)) {
   240			ret = PTR_ERR(rtc->rtc_dev);
   241			goto err;
   242		}
   243		rtc->rtc_dev->range_max = U32_MAX;
   244		rtc->rtc_dev->ops = &cv800b_rtc_ops;
   245	
 > 246		return rtc_register_device(rtc->rtc_dev);
   247	err:
   248		return dev_err_probe(&pdev->dev, ret, "Failed to init cv1800b rtc\n");
   249	}
   250	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki