linux-kernel - Re: [PATCH v3 2/2] power: supply: bq24190

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202311220126.8UPRiJN0-lkp@intel.com>
Date:   Wed, 22 Nov 2023 02:08:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hermes Zhang <Hermes.Zhang@...s.com>, sre@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel@...s.com, Hermes Zhang <chenhuiz@...s.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 2/2] power: supply: bq24190_charger: Add support for
  BQ24296

Hi Hermes,

kernel test robot noticed the following build errors:

[auto build test ERROR on sre-power-supply/for-next]
[also build test ERROR on linus/master v6.7-rc2 next-20231121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hermes-Zhang/dt-bindings-power-supply-bq24190-Add-BQ24296-compatible/20231121-151103
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20231121070505.3061304-3-Hermes.Zhang%40axis.com
patch subject: [PATCH v3 2/2] power: supply: bq24190_charger: Add support for  BQ24296
config: x86_64-buildonly-randconfig-004-20231121 (https://download.01.org/0day-ci/archive/20231122/202311220126.8UPRiJN0-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/202311220126.8UPRiJN0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311220126.8UPRiJN0-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/power/supply/bq24190_charger.c:1975:16: error: initializer element is not constant
      .vbus_desc = bq24190_vbus_desc,
                   ^~~~~~~~~~~~~~~~~
   drivers/power/supply/bq24190_charger.c:1975:16: note: (near initialization for 'bq24190_chip_info_tbl[0].vbus_desc')
   drivers/power/supply/bq24190_charger.c:1984:16: error: initializer element is not constant
      .vbus_desc = bq24190_vbus_desc,
                   ^~~~~~~~~~~~~~~~~
   drivers/power/supply/bq24190_charger.c:1984:16: note: (near initialization for 'bq24190_chip_info_tbl[1].vbus_desc')
   drivers/power/supply/bq24190_charger.c:1993:16: error: initializer element is not constant
      .vbus_desc = bq24190_vbus_desc,
                   ^~~~~~~~~~~~~~~~~
   drivers/power/supply/bq24190_charger.c:1993:16: note: (near initialization for 'bq24190_chip_info_tbl[2].vbus_desc')
   drivers/power/supply/bq24190_charger.c:2002:16: error: initializer element is not constant
      .vbus_desc = bq24190_vbus_desc,
                   ^~~~~~~~~~~~~~~~~
   drivers/power/supply/bq24190_charger.c:2002:16: note: (near initialization for 'bq24190_chip_info_tbl[3].vbus_desc')
   drivers/power/supply/bq24190_charger.c:2011:16: error: initializer element is not constant
      .vbus_desc = bq24296_vbus_desc,
                   ^~~~~~~~~~~~~~~~~
   drivers/power/supply/bq24190_charger.c:2011:16: note: (near initialization for 'bq24190_chip_info_tbl[4].vbus_desc')


vim +1975 drivers/power/supply/bq24190_charger.c

  1971	
  1972	static const struct bq24190_chip_info bq24190_chip_info_tbl[] = {
  1973		[BQ24190] = {
  1974			.ichg_array_size = ARRAY_SIZE(bq24190_ccc_ichg_values),
> 1975			.vbus_desc = bq24190_vbus_desc,
  1976			.check_chip = bq24190_check_chip,
  1977			.set_chg_config = bq24190_battery_set_chg_config,
  1978			.ntc_fault_mask = BQ24190_REG_F_NTC_FAULT_MASK,
  1979			.get_ntc_status = bq24190_charger_get_ntc_status,
  1980			.set_otg_vbus = bq24190_set_otg_vbus,
  1981		},
  1982		[BQ24192] = {
  1983			.ichg_array_size = ARRAY_SIZE(bq24190_ccc_ichg_values),
  1984			.vbus_desc = bq24190_vbus_desc,
  1985			.check_chip = bq24190_check_chip,
  1986			.set_chg_config = bq24190_battery_set_chg_config,
  1987			.ntc_fault_mask = BQ24190_REG_F_NTC_FAULT_MASK,
  1988			.get_ntc_status = bq24190_charger_get_ntc_status,
  1989			.set_otg_vbus = bq24190_set_otg_vbus,
  1990		},
  1991		[BQ24192i] = {
  1992			.ichg_array_size = ARRAY_SIZE(bq24190_ccc_ichg_values),
  1993			.vbus_desc = bq24190_vbus_desc,
  1994			.check_chip = bq24190_check_chip,
  1995			.set_chg_config = bq24190_battery_set_chg_config,
  1996			.ntc_fault_mask = BQ24190_REG_F_NTC_FAULT_MASK,
  1997			.get_ntc_status = bq24190_charger_get_ntc_status,
  1998			.set_otg_vbus = bq24190_set_otg_vbus,
  1999		},
  2000		[BQ24196] = {
  2001			.ichg_array_size = ARRAY_SIZE(bq24190_ccc_ichg_values),
  2002			.vbus_desc = bq24190_vbus_desc,
  2003			.check_chip = bq24190_check_chip,
  2004			.set_chg_config = bq24190_battery_set_chg_config,
  2005			.ntc_fault_mask = BQ24190_REG_F_NTC_FAULT_MASK,
  2006			.get_ntc_status = bq24190_charger_get_ntc_status,
  2007			.set_otg_vbus = bq24190_set_otg_vbus,
  2008		},
  2009		[BQ24296] = {
  2010			.ichg_array_size = BQ24296_CCC_ICHG_VALUES_LEN,
  2011			.vbus_desc = bq24296_vbus_desc,
  2012			.check_chip = bq24296_check_chip,
  2013			.set_chg_config = bq24296_battery_set_chg_config,
  2014			.ntc_fault_mask = BQ24296_REG_F_NTC_FAULT_MASK,
  2015			.get_ntc_status = bq24296_charger_get_ntc_status,
  2016			.set_otg_vbus = bq24296_set_otg_vbus,
  2017		},
  2018	};
  2019	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki